implement default analysis options in bazel

implement default analysis options in bazel

* if no analysis options file is found using the default search algorithm,
  check for options in package:dart.analysis_options/default.yaml
* implement common workspace superclass

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3dba1f9e3674b2b3d9c7e27a2414fd3863389135

[danrubel, 2017-01-30 14:25:54]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-01-30 14:56:06]

lgtm

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:408: source =
Merge initialization with declaration?

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/builder_test.dart (right):

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/builder_test.dart:527: void
test_getAnalysisOptions_default_bazel() {
Should we have a similar test for Gn?

[danrubel, 2017-01-30 18:59:49]

Description was changed from

==========
implement default analysis options in bazel

* if no analysis options file is found using the default search algorithm,
  check for options in package:dart.analysis_options/default.yaml
* implement common workspace superclass
==========

to

==========
implement default analysis options in bazel

* if no analysis options file is found using the default search algorithm,
  check for options in package:dart.analysis_options/default.yaml
* implement common workspace superclass

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3dba1f9e3674b2b3d9c7e27a2414fd3863389135
==========

[danrubel, 2017-01-30 18:59:51]

Committed patchset #4 (id:60001) manually as
3dba1f9e3674b2b3d9c7e27a2414fd3863389135 (presubmit successful).

[danrubel, 2017-01-30 19:00:44]

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:408: source =
On 2017/01/30 14:56:05, Brian Wilkerson wrote:
> Merge initialization with declaration?

Done.

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/builder_test.dart (right):

https://codereview.chromium.org/2660173002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/builder_test.dart:527: void
test_getAnalysisOptions_default_bazel() {
On 2017/01/30 14:56:05, Brian Wilkerson wrote:
> Should we have a similar test for Gn?

Good point, but I don't know an appropriate default for Gn. I can implement and
add a test in a subsequent CL once we determine a proper course of action.