Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3792)

Unified Diff: chrome/browser/win/jumplist.cc

Issue 2660153002: Incognito icon added to Windows taskbar jumplist. (Closed)
Patch Set: Resource file modified for branded build. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/win/jumplist.cc
diff --git a/chrome/browser/win/jumplist.cc b/chrome/browser/win/jumplist.cc
index 508093dfa290fa460552fa29d95bdf17c8b071eb..d31e8c7c735af0c90564e9db4d6976c7170469d6 100644
--- a/chrome/browser/win/jumplist.cc
+++ b/chrome/browser/win/jumplist.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/sessions/tab_restore_service_factory.h"
#include "chrome/browser/shell_integration_win.h"
#include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_icon_resources_win.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
@@ -137,8 +138,7 @@ bool UpdateTaskCategory(
}
// Create an IShellLink object which launches Chrome in incognito mode, and
- // add it to the collection. We use our application icon as the icon for
- // this item.
+ // add it to the collection.
if (incognito_availability != IncognitoModePrefs::DISABLED) {
scoped_refptr<ShellLinkItem> incognito = CreateShellLink();
incognito->GetCommandLine()->AppendSwitch(switches::kIncognito);
@@ -147,7 +147,7 @@ bool UpdateTaskCategory(
base::ReplaceSubstringsAfterOffset(
&incognito_title, 0, L"&", base::StringPiece16());
incognito->set_title(incognito_title);
- incognito->set_icon(chrome_path.value(), icon_index);
+ incognito->set_icon(chrome_path.value(), icon_resources::kIncognitoIndex);
items.push_back(incognito);
}

Powered by Google App Engine
This is Rietveld 408576698