Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2660143002: Removing iPad Tab Switcher experimental flag. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/snapshots/snapshot_cache_unittest.mm ('k') | ios/chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index cd84b0fce7d043e1daa43e47cafd2d575580e404..a376f6accd950e350c904b89f7a05a83115bff70 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1789,16 +1789,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
finishPageLoadForTab:self
loadSuccess:loadSuccess];
- // Always take snapshots on iPad if the tab switcher is enabled.
- // If the tab switcher is not enabled, don't take snapshot of chrome scheme
- // pages.
- BOOL takeSnapshotOnIpad =
- IsIPadIdiom() &&
- (experimental_flags::IsTabSwitcherEnabled() ||
- !web::GetWebClient()->IsAppSpecificURL(lastCommittedURL));
- // Always take snapshot on iPhone.
- BOOL takeSnapshot = !IsIPadIdiom() || takeSnapshotOnIpad;
- if (loadSuccess && takeSnapshot) {
+ if (loadSuccess) {
[self updateSnapshotWithOverlay:YES visibleFrameOnly:YES];
}
[webControllerSnapshotHelper_ setSnapshotCoalescingEnabled:NO];
« no previous file with comments | « ios/chrome/browser/snapshots/snapshot_cache_unittest.mm ('k') | ios/chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698