Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Issue 2660143002: Removing iPad Tab Switcher experimental flag. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
index d6d01e0b81420951da64e314f9ba6f99adf4dfd6..58a7b3678c3d9814ee5a083336f65ad9663083b1 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
+++ b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
@@ -163,29 +163,21 @@ void SwitchToNormalMode() {
GREYAssertTrue(chrome_test_util::IsIncognitoMode(),
@"Switching to normal mode is only allowed from Incognito.");
if (IsIPadIdiom()) {
- if (experimental_flags::IsTabSwitcherEnabled()) {
- // Enter the tab switcher.
- id<GREYMatcher> tabSwitcherEnterButton =
- grey_accessibilityLabel(l10n_util::GetNSStringWithFixup(
- IDS_IOS_TAB_STRIP_ENTER_TAB_SWITCHER));
- [[EarlGrey selectElementWithMatcher:tabSwitcherEnterButton]
- performAction:grey_tap()];
-
- // Select the non incognito panel.
- id<GREYMatcher> tabSwitcherHeaderPanelButton =
- grey_accessibilityLabel(l10n_util::GetNSStringWithFixup(
- IDS_IOS_TAB_SWITCHER_HEADER_NON_INCOGNITO_TABS));
- [[EarlGrey selectElementWithMatcher:tabSwitcherHeaderPanelButton]
- performAction:grey_tap()];
-
- // Leave the tab switcher.
- CloseTabSwitcher();
- } else {
- [[EarlGrey selectElementWithMatcher:
- chrome_test_util::ButtonWithAccessibilityLabelId(
- IDS_IOS_SWITCH_BROWSER_MODE_LEAVE_INCOGNITO)]
- performAction:grey_tap()];
- }
+ // Enter the tab switcher.
+ id<GREYMatcher> tabSwitcherEnterButton = grey_accessibilityLabel(
+ l10n_util::GetNSStringWithFixup(IDS_IOS_TAB_STRIP_ENTER_TAB_SWITCHER));
+ [[EarlGrey selectElementWithMatcher:tabSwitcherEnterButton]
+ performAction:grey_tap()];
+
+ // Select the non incognito panel.
+ id<GREYMatcher> tabSwitcherHeaderPanelButton =
+ grey_accessibilityLabel(l10n_util::GetNSStringWithFixup(
+ IDS_IOS_TAB_SWITCHER_HEADER_NON_INCOGNITO_TABS));
+ [[EarlGrey selectElementWithMatcher:tabSwitcherHeaderPanelButton]
+ performAction:grey_tap()];
+
+ // Leave the tab switcher.
+ CloseTabSwitcher();
} else {
[[EarlGrey selectElementWithMatcher:
chrome_test_util::ButtonWithAccessibilityLabelId(
« no previous file with comments | « ios/chrome/browser/experimental_flags.mm ('k') | ios/chrome/browser/resources/Settings.bundle/Experimental.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698