Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2660143002: Removing iPad Tab Switcher experimental flag. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index e2b6d8c129ec30bc83f63b9d3856f8bdaf7d7b8f..60423c974ed02497b28b05e3d61869c9dee8c1a2 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1790,16 +1790,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
finishPageLoadForTab:self
loadSuccess:loadSuccess];
- // Always take snapshots on iPad if the tab switcher is enabled.
- // If the tab switcher is not enabled, don't take snapshot of chrome scheme
- // pages.
- BOOL takeSnapshotOnIpad =
- IsIPadIdiom() &&
- (experimental_flags::IsTabSwitcherEnabled() ||
- !web::GetWebClient()->IsAppSpecificURL(lastCommittedURL));
- // Always take snapshot on iPhone.
- BOOL takeSnapshot = !IsIPadIdiom() || takeSnapshotOnIpad;
- if (loadSuccess && takeSnapshot) {
+ if (loadSuccess) {
[self updateSnapshotWithOverlay:YES visibleFrameOnly:YES];
}
[webControllerSnapshotHelper_ setSnapshotCoalescingEnabled:NO];

Powered by Google App Engine
This is Rietveld 408576698