Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: ios/chrome/browser/about_flags.mm

Issue 2660143002: Removing iPad Tab Switcher experimental flag. (Closed)
Patch Set: Rebased. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/app/main_controller.mm ('k') | ios/chrome/browser/chrome_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Implementation of about_flags for iOS that sets flags based on experimental 5 // Implementation of about_flags for iOS that sets flags based on experimental
6 // settings. 6 // settings.
7 7
8 #include "ios/chrome/browser/about_flags.h" 8 #include "ios/chrome/browser/about_flags.h"
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 BUILDFLAG(GOOGLE_TEST_OAUTH_CLIENT_ID)); 96 BUILDFLAG(GOOGLE_TEST_OAUTH_CLIENT_ID));
97 command_line->AppendSwitchASCII(switches::kOAuth2ClientSecret, 97 command_line->AppendSwitchASCII(switches::kOAuth2ClientSecret,
98 BUILDFLAG(GOOGLE_TEST_OAUTH_CLIENT_SECRET)); 98 BUILDFLAG(GOOGLE_TEST_OAUTH_CLIENT_SECRET));
99 } 99 }
100 100
101 // Populate command line flag for the tab strip auto scroll new tabs 101 // Populate command line flag for the tab strip auto scroll new tabs
102 // experiment from the configuration plist. 102 // experiment from the configuration plist.
103 if ([defaults boolForKey:@"TabStripAutoScrollNewTabsDisabled"]) 103 if ([defaults boolForKey:@"TabStripAutoScrollNewTabsDisabled"])
104 command_line->AppendSwitch(switches::kDisableTabStripAutoScrollNewTabs); 104 command_line->AppendSwitch(switches::kDisableTabStripAutoScrollNewTabs);
105 105
106 // Populate command line flag for the Tab Switcher experiment from the
107 // configuration plist.
108 NSString* enableTabSwitcher = [defaults stringForKey:@"EnableTabSwitcher"];
109 if ([enableTabSwitcher isEqualToString:@"Enabled"]) {
110 command_line->AppendSwitch(switches::kEnableTabSwitcher);
111 } else if ([enableTabSwitcher isEqualToString:@"Disabled"]) {
112 command_line->AppendSwitch(switches::kDisableTabSwitcher);
113 }
114
115 // Populate command line flag for the SnapshotLRUCache experiment from the 106 // Populate command line flag for the SnapshotLRUCache experiment from the
116 // configuration plist. 107 // configuration plist.
117 NSString* enableLRUSnapshotCache = 108 NSString* enableLRUSnapshotCache =
118 [defaults stringForKey:@"SnapshotLRUCache"]; 109 [defaults stringForKey:@"SnapshotLRUCache"];
119 if ([enableLRUSnapshotCache isEqualToString:@"Enabled"]) { 110 if ([enableLRUSnapshotCache isEqualToString:@"Enabled"]) {
120 command_line->AppendSwitch(switches::kEnableLRUSnapshotCache); 111 command_line->AppendSwitch(switches::kEnableLRUSnapshotCache);
121 } else if ([enableLRUSnapshotCache isEqualToString:@"Disabled"]) { 112 } else if ([enableLRUSnapshotCache isEqualToString:@"Disabled"]) {
122 command_line->AppendSwitch(switches::kDisableLRUSnapshotCache); 113 command_line->AppendSwitch(switches::kDisableLRUSnapshotCache);
123 } 114 }
124 115
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 } 323 }
333 324
334 namespace testing { 325 namespace testing {
335 326
336 const flags_ui::FeatureEntry* GetFeatureEntries(size_t* count) { 327 const flags_ui::FeatureEntry* GetFeatureEntries(size_t* count) {
337 *count = arraysize(kFeatureEntries); 328 *count = arraysize(kFeatureEntries);
338 return kFeatureEntries; 329 return kFeatureEntries;
339 } 330 }
340 331
341 } // namespace testing 332 } // namespace testing
OLDNEW
« no previous file with comments | « ios/chrome/app/main_controller.mm ('k') | ios/chrome/browser/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698