Removing iPad Tab Switcher experimental flag.

ios/chrome/browser/snapshots/snapshot_cache.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/snapshots/snapshot_cache.h"
 
 #import <UIKit/UIKit.h>
 
 #include "base/critical_closure.h"
 #include "base/files/file_enumerator.h"
@@ skipping 387 matching lines @@
   if (lruCache_) {
     backgroundingColorImage_.reset([[lruCache_ objectForKey:sessionID] retain]);
   } else {
     backgroundingColorImage_.reset(
         [[imageDictionary_ objectForKey:sessionID] retain]);
   }
 }
 
 - (BOOL)inMemoryCacheIsEnabled {
   // In-memory cache on iPad is enabled only when the tab switcher is enabled.
-  return !IsIPadIdiom() || experimental_flags::IsTabSwitcherEnabled();
+  return !IsIPadIdiom();

[rohitrao (ping after 24h), 2017/02/01 18:34:34]

It looks like the old implementation always returned true, so this is a change
in behavior?

[jif, 2017/02/03 12:55:50]

It is! Thank you.
Done.

 }
 
 - (BOOL)usesLRUCache {
   // Always use the LRUCache when the tab switcher is enabled.
-  return experimental_flags::IsTabSwitcherEnabled() ||
-         experimental_flags::IsLRUSnapshotCacheEnabled();
+  return experimental_flags::IsLRUSnapshotCacheEnabled();

[rohitrao (ping after 24h), 2017/02/01 18:34:34]

Same here.

[jif, 2017/02/03 12:55:51]

Done.

 }
 
 - (void)handleLowMemory {
   DCHECK_CURRENTLY_ON(web::WebThread::UI);
   base::scoped_nsobject<NSMutableDictionary> dictionary(
       [[NSMutableDictionary alloc] initWithCapacity:2]);
   for (NSString* sessionID in pinnedIDs_) {
     UIImage* image = nil;
     if (lruCache_)
       image = [lruCache_ objectForKey:sessionID];
@@ skipping 177 matching lines @@
 
 - (BOOL)hasGreyImageInMemory:(NSString*)sessionID {
   return [greyImageDictionary_ objectForKey:sessionID] != nil;
 }
 
 - (NSUInteger)lruCacheMaxSize {
   return [lruCache_ maxCacheSize];
 }
 
 @end