Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: extensions/renderer/dom_activity_logger.h

Issue 266013004: Cleanup after WebKit update to pass old values to activity log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 17 matching lines...) Expand all
28 namespace extensions { 28 namespace extensions {
29 29
30 // Used to log DOM API calls from within WebKit. The events are sent via IPC to 30 // Used to log DOM API calls from within WebKit. The events are sent via IPC to
31 // extensions::ActivityLog for recording and display. 31 // extensions::ActivityLog for recording and display.
32 class DOMActivityLogger: public blink::WebDOMActivityLogger { 32 class DOMActivityLogger: public blink::WebDOMActivityLogger {
33 public: 33 public:
34 static const int kMainWorldId = 0; 34 static const int kMainWorldId = 0;
35 explicit DOMActivityLogger(const std::string& extension_id); 35 explicit DOMActivityLogger(const std::string& extension_id);
36 virtual ~DOMActivityLogger(); 36 virtual ~DOMActivityLogger();
37 37
38 // This will soon be deprecated, and converted to the logX methods below.
39 virtual void log(const blink::WebString& api_name,
40 int argc,
41 const v8::Handle<v8::Value> argv[],
42 const blink::WebString& call_type,
43 const blink::WebURL& url,
44 const blink::WebString& title);
45
46 // Check (using the WebKit API) if there is no logger attached to the world 38 // Check (using the WebKit API) if there is no logger attached to the world
47 // corresponding to world_id, and if so, construct a new logger and attach it. 39 // corresponding to world_id, and if so, construct a new logger and attach it.
48 // world_id = 0 indicates the main world. 40 // world_id = 0 indicates the main world.
49 static void AttachToWorld(int world_id, 41 static void AttachToWorld(int world_id,
50 const std::string& extension_id); 42 const std::string& extension_id);
51 43
52 private: 44 private:
53 // blink::WebDOMActivityLogger implementation. 45 // blink::WebDOMActivityLogger implementation.
54 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends 46 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends
55 // it over to the browser (via IPC) for appending it to the extension activity 47 // it over to the browser (via IPC) for appending it to the extension activity
(...skipping 28 matching lines...) Expand all
84 // The id of the extension with which this logger is associated. 76 // The id of the extension with which this logger is associated.
85 std::string extension_id_; 77 std::string extension_id_;
86 78
87 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger); 79 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger);
88 }; 80 };
89 81
90 } // namespace extensions 82 } // namespace extensions
91 83
92 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 84 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
93 85
OLDNEW
« no previous file with comments | « no previous file | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698