Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 266013004: Cleanup after WebKit update to pass old values to activity log (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup after WebKit update to pass old values to activity log Remove the now-unused log() function from DOMActivityLogger. BUG=356890 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M extensions/renderer/dom_activity_logger.h View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Webkit patch went in Friday, so we can take out the old logs now.
6 years, 7 months ago (2014-05-05 16:34:05 UTC) #1
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-05 16:36:27 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-05 16:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/266013004/1
6 years, 7 months ago (2014-05-05 16:38:29 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 19:41:24 UTC) #5
Message was sent while issue was closed.
Change committed as 268247

Powered by Google App Engine
This is Rietveld 408576698