Issue 2660073002: ContextBuilder should to throw when a root folder does not exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2660073002: ContextBuilder should to throw when a root folder does not exist. (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

ContextBuilder should to throw when a root folder does not exist. Otherwise, removing an analysis root with .analysis_options file causes an exception. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2acfb1d81861dadc3e5f9f919f8258a28d066309

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -2 lines)			Patch
M	pkg/analysis_server/test/context_manager_test.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/builder.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/context/builder_test.dart	View	2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 10 months ago (2017-01-29 17:37:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2acfb1d81861dadc3e5f9f919f8258a28d066309 (presubmit successful).