Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2660003003: Add MediaError.message (Closed)
Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index 959631b40cca8fcf31cc8f83b13e9706a7a018e9..8f0f57a679be2e2307ce886f158e61ecf6fc5f52 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -40,6 +40,9 @@
#include "cc/paint/paint_flags.h"
+#include <map>
+#include <vector>
+
namespace gpu {
namespace gles2 {
class GLES2Interface;
@@ -159,7 +162,11 @@ class WebMediaPlayer {
virtual NetworkState GetNetworkState() const = 0;
virtual ReadyState GetReadyState() const = 0;
- virtual WebString GetErrorMessage() = 0;
+ // Returns an implementation-specific map of error message types to a vector
+ // of error messages of that type for use in reporting to the web application.
+ virtual std::map<std::string, std::vector<std::string>> GetErrorMessages()
+ const = 0;
+
virtual bool DidLoadingProgress() = 0;
virtual bool HasSingleSecurityOrigin() const = 0;

Powered by Google App Engine
This is Rietveld 408576698