third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h - Issue 2660003003: Add MediaError.message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h

Issue 2660003003: Add MediaError.message (Closed)

Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h

diff --git a/third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h b/third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h

index 5055b81242a87b1b174dcca5e66a74c7f3a94985..0be1969b04f28ffbaae9744d12ad984356d99265 100644

--- a/third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h

+++ b/third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h

@@ -37,7 +37,8 @@ class EmptyWebMediaPlayer : public WebMediaPlayer {

double CurrentTime() const override { return 0.0; }

NetworkState GetNetworkState() const override { return kNetworkStateEmpty; }

ReadyState GetReadyState() const override { return kReadyStateHaveNothing; }

- WebString GetErrorMessage() override { return WebString(); }

+ std::map<std::string, std::vector<std::string>> GetErrorMessages()

+ const override;

bool DidLoadingProgress() override { return false; }

bool HasSingleSecurityOrigin() const override { return true; }

bool DidPassCORSAccessCheck() const override { return true; }