Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: media/base/media_log.h

Issue 2660003003: Add MediaError.message (Closed)
Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index cb0a6b622aabebf1853f7c26e5cf42f9352808fd..1a6e71667d6e9e6954119f1f80a61a2331bb23e5 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -8,9 +8,11 @@
#include <stddef.h>
#include <stdint.h>
+#include <map>
#include <memory>
#include <sstream>
#include <string>
+#include <vector>
#include "base/containers/flat_set.h"
#include "base/logging.h"
@@ -40,7 +42,8 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
static std::string PipelineStatusToString(PipelineStatus status);
static std::string BufferingStateToString(BufferingState state);
- static std::string MediaEventToLogString(const MediaLogEvent& event);
+ static std::string MediaEventToLogString(const MediaLogEvent& event,
+ bool include_type);
MediaLog();
@@ -48,8 +51,8 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
// with it.
virtual void AddEvent(std::unique_ptr<MediaLogEvent> event);
- // Retrieve an error message, if any.
- virtual std::string GetLastErrorMessage();
+ // Retrieve error messages, if any, keyed by error type.
+ virtual std::map<std::string, std::vector<std::string>> GetErrorMessages();
// Records the domain and registry of the current frame security origin to a
// Rappor privacy-preserving metric. See:

Powered by Google App Engine
This is Rietveld 408576698