content/renderer/media/webmediaplayer_ms.cc - Issue 2660003003: Add MediaError.message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2660003003: Add MediaError.message (Closed)

Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_ms.cc

diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc

index 98f53696015e6367e7efca0d852566b36c38d788..32b77f0c56e00ac80f8fe707a69192dd451f3654 100644

--- a/content/renderer/media/webmediaplayer_ms.cc

+++ b/content/renderer/media/webmediaplayer_ms.cc

@@ -422,8 +422,9 @@ blink::WebMediaPlayer::ReadyState WebMediaPlayerMS::GetReadyState() const {

return ready_state_;

}

-blink::WebString WebMediaPlayerMS::GetErrorMessage() {

- return blink::WebString::FromUTF8(media_log_->GetLastErrorMessage());

+std::map<std::string, std::vector<std::string>>

+WebMediaPlayerMS::GetErrorMessages() const {

+ return media_log_->GetErrorMessages();

}

blink::WebTimeRanges WebMediaPlayerMS::Buffered() const {