third_party/WebKit/public/platform/WebMediaPlayer.h - Issue 2660003003: Add MediaError.message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2660003003: Add MediaError.message (Closed)

Patch Set: Simplify to just 1 string with no newlines: [status plus first MEDIA_ERROR_LOG_ENTRY], if any Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebMediaPlayer.h

diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h

index 4f17e2e0172cee478408227f14c4209c80e7557d..873d4ee5489f60ea9e74b29c32048b2d5a6690e7 100644

--- a/third_party/WebKit/public/platform/WebMediaPlayer.h

+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h

@@ -159,7 +159,10 @@ class WebMediaPlayer {

virtual NetworkState GetNetworkState() const = 0;

virtual ReadyState GetReadyState() const = 0;

- virtual WebString GetErrorMessage() = 0;

+ // Returns an implementation-specific human readable error message, or an

+ // empty string if no error detail is available.

+ virtual WebString GetErrorMessage() const = 0;

virtual bool DidLoadingProgress() = 0;

virtual bool HasSingleSecurityOrigin() const = 0;