media/blink/webmediaplayer_impl.cc - Issue 2660003003: Add MediaError.message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2660003003: Add MediaError.message (Closed)

Patch Set: Simplify to just 1 string with no newlines: [status plus first MEDIA_ERROR_LOG_ENTRY], if any Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 20796d389172f5ac853bef2b1ce8fe03faed70a3..200937bf0f8fba5355c199ae9fbf7cda48b1f3aa 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -783,9 +783,9 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::GetReadyState() const {

return ready_state_;

}

-blink::WebString WebMediaPlayerImpl::GetErrorMessage() {

+blink::WebString WebMediaPlayerImpl::GetErrorMessage() const {

DCHECK(main_task_runner_->BelongsToCurrentThread());

- return blink::WebString::FromUTF8(media_log_->GetLastErrorMessage());

+ return blink::WebString::FromUTF8(media_log_->GetErrorMessage());

}

blink::WebTimeRanges WebMediaPlayerImpl::Buffered() const {