Add MediaError.message

content/browser/media/media_browsertest.h

Index: content/browser/media/media_browsertest.h
diff --git a/content/browser/media/media_browsertest.h b/content/browser/media/media_browsertest.h
index 238b6678c3e2c4098fa049805269d1de54e8f8cb..c2f70478e7f4e4e194b6c857bc1f2a50838e3d29 100644
--- a/content/browser/media/media_browsertest.h
+++ b/content/browser/media/media_browsertest.h
@@ -39,6 +39,11 @@ class MediaBrowserTest : public ContentBrowserTest {
   // titles. Returns the matching title.
   std::string RunTest(const GURL& gurl, const std::string& expected_title);
 
+  // Encodes |original_message| to be used in a URI query parameter suitable for
+  // decoding and usage with DecodeURIComponent in test pages that verify error
+  // message contents.
+  std::string EncodeErrorMessage(const std::string& original_message);

[mlamouri (slow - plz ping), 2017/04/18 12:37:59]

It doesn't sound like you need this to be part of the class but instead could be
part of the anonymous namespace. Any specific reason why it's part of the
header?

[wolenetz, 2017/04/18 17:53:06]

In this particular patch set, you're correct: this method is only locally used
and could be moved to anonymous namespace within the impl
(media_browsertest.cc). However, I foresee we may want to have similar error
message testing later on in other kinds of MediaBrowserTest, so put it here to
make it more obvious that this method is here and help reduce possibility of
eventual duplication of this functionality. No other strong feeling here, so if
you feel strongly, I'll move it to the impl.

+
   // Adds titles that RunTest() should wait for.
   virtual void AddTitlesToAwait(content::TitleWatcher* title_watcher);
 };