chrome/browser/chromeos/options/DEPS - Issue 2659973003: [Harmony] Harmony Chrome OS Wifi dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/options/DEPS

Issue 2659973003: [Harmony] Harmony Chrome OS Wifi dialog. (Closed)

Patch Set: Address oshima@'s comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 # TODO(xdai): Remove this DEPS file after layout_delegate.h/cc is moved to a

	3 # better place.

	4 "!chrome/browser/ui/views/harmony/layout_delegate.h",
	xiyuan 2017/01/30 16:59:10 Would "gn check" be happy about this? Would "gn check" be happy about this? xdai1 2017/01/30 18:46:36 The dry run passed. So I guess it's happy? ellyjon Show quoted text On 2017/01/30 16:59:10, xiyuan wrote: > Would "gn check" be happy about this? The dry run passed. So I guess it's happy? ellyjones@, do you know why these files harmony/layout_delgate.h/cc were put in chrome/browser/ui/views directory？
	5 ]

	6

OLD	NEW