Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2659943002: Implement SourceFactory.forUri2() to fix front_end after f28e8afb23b2. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement SourceFactory.forUri2() to fix front_end after f28e8afb23b2. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0888722a53d732115ba552ddf5eecca472e4e407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-01-27 17:33:42 UTC) #1
Paul Berry
lgtm. Thank you!
3 years, 10 months ago (2017-01-27 17:35:11 UTC) #2
scheglov
3 years, 10 months ago (2017-01-27 17:35:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0888722a53d732115ba552ddf5eecca472e4e407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698