Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: include/v8-inspector.h

Issue 2659913002: V8 Inspector: complete migration to the standard message level enum. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/v8-console-message.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_V8_INSPECTOR_H_ 5 #ifndef V8_V8_INSPECTOR_H_
6 #define V8_V8_INSPECTOR_H_ 6 #define V8_V8_INSPECTOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <cctype> 9 #include <cctype>
10 10
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 virtual std::unique_ptr<protocol::Runtime::API::RemoteObject> wrapObject( 149 virtual std::unique_ptr<protocol::Runtime::API::RemoteObject> wrapObject(
150 v8::Local<v8::Context>, v8::Local<v8::Value>, 150 v8::Local<v8::Context>, v8::Local<v8::Value>,
151 const StringView& groupName) = 0; 151 const StringView& groupName) = 0;
152 virtual bool unwrapObject(std::unique_ptr<StringBuffer>* error, 152 virtual bool unwrapObject(std::unique_ptr<StringBuffer>* error,
153 const StringView& objectId, v8::Local<v8::Value>*, 153 const StringView& objectId, v8::Local<v8::Value>*,
154 v8::Local<v8::Context>*, 154 v8::Local<v8::Context>*,
155 std::unique_ptr<StringBuffer>* objectGroup) = 0; 155 std::unique_ptr<StringBuffer>* objectGroup) = 0;
156 virtual void releaseObjectGroup(const StringView&) = 0; 156 virtual void releaseObjectGroup(const StringView&) = 0;
157 }; 157 };
158 158
159 enum class V8ConsoleAPIType { kClear, kDebug, kLog, kInfo, kWarning, kError };
160
161 class V8_EXPORT V8InspectorClient { 159 class V8_EXPORT V8InspectorClient {
162 public: 160 public:
163 virtual ~V8InspectorClient() {} 161 virtual ~V8InspectorClient() {}
164 162
165 virtual void runMessageLoopOnPause(int contextGroupId) {} 163 virtual void runMessageLoopOnPause(int contextGroupId) {}
166 virtual void quitMessageLoopOnPause() {} 164 virtual void quitMessageLoopOnPause() {}
167 virtual void runIfWaitingForDebugger(int contextGroupId) {} 165 virtual void runIfWaitingForDebugger(int contextGroupId) {}
168 166
169 virtual void muteMetrics(int contextGroupId) {} 167 virtual void muteMetrics(int contextGroupId) {}
170 virtual void unmuteMetrics(int contextGroupId) {} 168 virtual void unmuteMetrics(int contextGroupId) {}
(...skipping 11 matching lines...) Expand all
182 180
183 virtual v8::Local<v8::Context> ensureDefaultContextInGroup( 181 virtual v8::Local<v8::Context> ensureDefaultContextInGroup(
184 int contextGroupId) { 182 int contextGroupId) {
185 return v8::Local<v8::Context>(); 183 return v8::Local<v8::Context>();
186 } 184 }
187 virtual void beginEnsureAllContextsInGroup(int contextGroupId) {} 185 virtual void beginEnsureAllContextsInGroup(int contextGroupId) {}
188 virtual void endEnsureAllContextsInGroup(int contextGroupId) {} 186 virtual void endEnsureAllContextsInGroup(int contextGroupId) {}
189 187
190 virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, 188 virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
191 v8::Local<v8::Object>) {} 189 v8::Local<v8::Object>) {}
192 // Deprecated, to be replaced with v8::Isolate::MessageErrorLevel version.
193 virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType,
194 const StringView& message,
195 const StringView& url, unsigned lineNumber,
196 unsigned columnNumber, V8StackTrace*) {}
197 virtual void consoleAPIMessage(int contextGroupId, 190 virtual void consoleAPIMessage(int contextGroupId,
198 v8::Isolate::MessageErrorLevel level, 191 v8::Isolate::MessageErrorLevel level,
199 const StringView& message, 192 const StringView& message,
200 const StringView& url, unsigned lineNumber, 193 const StringView& url, unsigned lineNumber,
201 unsigned columnNumber, V8StackTrace*) {} 194 unsigned columnNumber, V8StackTrace*) {}
202 virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, 195 virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*,
203 v8::Local<v8::Context>) { 196 v8::Local<v8::Context>) {
204 return v8::MaybeLocal<v8::Value>(); 197 return v8::MaybeLocal<v8::Value>();
205 } 198 }
206 199
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 258
266 // API methods. 259 // API methods.
267 virtual std::unique_ptr<V8StackTrace> createStackTrace( 260 virtual std::unique_ptr<V8StackTrace> createStackTrace(
268 v8::Local<v8::StackTrace>) = 0; 261 v8::Local<v8::StackTrace>) = 0;
269 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0; 262 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0;
270 }; 263 };
271 264
272 } // namespace v8_inspector 265 } // namespace v8_inspector
273 266
274 #endif // V8_V8_INSPECTOR_H_ 267 #endif // V8_V8_INSPECTOR_H_
OLDNEW
« no previous file with comments | « no previous file | src/inspector/v8-console-message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698