Chromium Code Reviews
DescriptionChange MenuControllerDelegate to provide WeakPtr
So it is possible that a MenuControllerDelegate can be destroyed in a fashion
which does not notify the associated MenuController. This can leak to the
controller attempting to access the delegate after death.
Specifically a MenuControllerDelegate, which does not own the controller is
closed. Then at some point later on released as its Widgets are cleaned up.
The MenuController is then further interacted with, beginning to show another
menu.
Then at some point the MenuController is finally shutdown. Notifying all
associated delegates.
This change updates MenuControllerDelegate to provide a WeakPtr. MenuController
will verify existance before notifying delegates of shutdown.
TEST=MenuRunnerImplTest.NestedDelegateDestroyedWhileMenuRunning
BUG=683087
Patch Set 1 #
Messages
Total messages: 6 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||