Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/native/enqueue.dart

Issue 2659883002: Use entities in BackendClasses (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/native/enqueue.dart
diff --git a/pkg/compiler/lib/src/native/enqueue.dart b/pkg/compiler/lib/src/native/enqueue.dart
index 2b804bd44b4f92512f551e872c726a3d235538b9..1711562534628924470ba0b1455e1d2204cf4384 100644
--- a/pkg/compiler/lib/src/native/enqueue.dart
+++ b/pkg/compiler/lib/src/native/enqueue.dart
@@ -450,8 +450,8 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
registerInstantiation(type);
} else if (type == commonElements.boolType) {
registerInstantiation(type);
- } else if (compiler.types.isSubtype(
- type, backend.backendClasses.listImplementation.rawType)) {
+ } else if (type.asInstanceOf(backend.backendClasses.listClass) !=
Siggi Cherem (dart-lang) 2017/01/27 16:49:06 any reason why use `asInstanceOf` and not keep `is
Johnni Winther 2017/01/30 10:00:12 [asInstanceOf] is sufficient here but not below --
+ null) {
registerInstantiation(type);
}
// TODO(johnniwinther): Improve spec string precision to handle type

Powered by Google App Engine
This is Rietveld 408576698