Use entities in BackendClasses

Use entities in BackendClasses

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/cb6d6c449ec5b9921e3251c045f7d7b6c4e12769

[Johnni Winther, 2017-01-27 12:11:46]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-27 16:49:07]

lgtm

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/backend_api.dart:433: /// implementations of `List`
in type masks. This is the `JSUnmodifiableArray` class.
long line

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:440: if (type ==
commonElements.intType) {
(optional) while we are here, minor readability nit: I'd merge many of these
cases:

if (type == commonElements.numType) {
  registerInstantiation(commonElements.intType);
  registerInstantiation(commonElements.doubleType);
} else if (type == commonElements.intType ||
    type == commonElements.doubleType ||
    type == commonElements.stringType ||
    type == commonElements.nullType ||
    type == commonElements.boolType ||
    type.asInstanceOf(backend.backendClasses.listClass) != null) {
  registerInstantiation(type);
}


(to make it clear that all we are doing is checking whether `type` is a native
type we want to register, but that the action is the same).

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:453: } else if
(type.asInstanceOf(backend.backendClasses.listClass) !=
any reason why use `asInstanceOf` and not keep `isSubtype`? we are still using
isSubtype further below.

[Johnni Winther, 2017-01-30 09:28:53]

Description was changed from

==========
Use entities in BackendClasses
==========

to

==========
Use entities in BackendClasses

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cb6d6c449ec5b9921e3251c045f7d7b6c4e12769
==========

[Johnni Winther, 2017-01-30 09:28:54]

Committed patchset #2 (id:20001) manually as
cb6d6c449ec5b9921e3251c045f7d7b6c4e12769 (presubmit successful).

[Johnni Winther, 2017-01-30 10:00:12]

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common/backend_api.dart:433: /// implementations of `List`
in type masks. This is the `JSUnmodifiableArray` class.
On 2017/01/27 16:49:06, Siggi Cherem (dart-lang) wrote:
> long line

Done.

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (right):

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:440: if (type ==
commonElements.intType) {
On 2017/01/27 16:49:06, Siggi Cherem (dart-lang) wrote:
> (optional) while we are here, minor readability nit: I'd merge many of these
> cases:
> 
> if (type == commonElements.numType) {
>   registerInstantiation(commonElements.intType);
>   registerInstantiation(commonElements.doubleType);
> } else if (type == commonElements.intType ||
>     type == commonElements.doubleType ||
>     type == commonElements.stringType ||
>     type == commonElements.nullType ||
>     type == commonElements.boolType ||
>     type.asInstanceOf(backend.backendClasses.listClass) != null) {
>   registerInstantiation(type);
> }
> 
> 
> (to make it clear that all we are doing is checking whether `type` is a native
> type we want to register, but that the action is the same).

Done.

https://codereview.chromium.org/2659883002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:453: } else if
(type.asInstanceOf(backend.backendClasses.listClass) !=
On 2017/01/27 16:49:06, Siggi Cherem (dart-lang) wrote:
> any reason why use `asInstanceOf` and not keep `isSubtype`? we are still using
> isSubtype further below.

[asInstanceOf] is sufficient here but not below -- and I need to avoid a warning
about `rawType` acces on [ClassEntity].

They will be aligned in time (i.e. all such queries must go through the
ResolutionWorldBuilder).