Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2659873002: Update documentation on `Isolate.removeOnExitListener` and others. (Closed)

Created:
3 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update documentation on `Isolate.removeOnExitListener` and others. Fixes issue #28535 BUG= http://dartbug.com/28535 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/b291f479bd758bc2ca7ec1b8f4cf0b5a515a1d95

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M sdk/lib/isolate/isolate.dart View 1 6 chunks +39 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-27 10:29:21 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2659873002/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/2659873002/diff/1/sdk/lib/isolate/isolate.dart#newcode392 sdk/lib/isolate/isolate.dart:392: * If the isolate is already dead, no ...
3 years, 10 months ago (2017-01-30 11:12:14 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/2659873002/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://codereview.chromium.org/2659873002/diff/1/sdk/lib/isolate/isolate.dart#newcode392 sdk/lib/isolate/isolate.dart:392: * If the isolate is already dead, no exit ...
3 years, 10 months ago (2017-01-30 12:08:14 UTC) #4
Lasse Reichstein Nielsen
3 years, 10 months ago (2017-01-30 12:08:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b291f479bd758bc2ca7ec1b8f4cf0b5a515a1d95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698