[MD settings] Data driven content setting subtext

chrome/browser/resources/settings/site_settings_page/site_settings_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-site-settings-page' is the settings page containing privacy and
  * security site settings.
  */
+
 Polymer({
   is: 'settings-site-settings-page',
 
   behaviors: [SiteSettingsBehavior, WebUIListenerBehavior],
 
   properties: {
     /**
-     * An object to bind default value labels to (so they are not in the |this|
+     * An object to bind default values to (so they are not in the |this|
      * scope). The keys of this object are the values of the
      * settings.ContentSettingsTypes enum.
      * @private
      */
     default_: {
       type: Object,
       value: function() {
         return {};
       },
     },
@@ skipping 25 matching lines @@
     this.addWebUIListener(
         'contentSettingCategoryChanged',
         this.updateDefaultValueLabel_.bind(this));
     this.addWebUIListener(
         'setHandlersEnabled',
         this.updateHandlersEnabled_.bind(this));
     this.browserProxy.observeProtocolHandlersEnabledState();
   },
 
   /**
+   * @param {string} setting Value from settings.PermissionValues.
+   * @param {string} enabled Non-block label ('feature X not allowed').
+   * @param {string} disabled Block label (likely just, 'Blocked').
+   * @param {?string} other Tristate value (maybe, 'session only').
+   * @private
+   */
+  defaultSettingLabel_: function(setting, enabled, disabled, other) {
+    if (setting == settings.PermissionValues.BLOCK)
+      return disabled;
+    if (setting == settings.PermissionValues.ALLOW)
+      return enabled;
+    if (other)
+      return other;
+    return enabled;
+  },
+
+  /**
    * @param {string} category The category to update.
    * @private
    */
   updateDefaultValueLabel_: function(category) {
     this.browserProxy.getDefaultValueForContentType(
         category).then(function(defaultValue) {
           this.set(
               'default_.' + Polymer.CaseMap.dashToCamelCase(category),
-              this.computeCategoryDesc(
-                  category,
-                  defaultValue.setting,
-                  /*showRecommendation=*/false));
+              defaultValue.setting);
         }.bind(this));
   },
 
   /**
    * The protocol handlers have a separate enabled/disabled notifier.
    * @param {boolean} enabled
    * @private
    */
   updateHandlersEnabled_: function(enabled) {
     var category = settings.ContentSettingsTypes.PROTOCOL_HANDLERS;
     this.set(
         'default_.' + Polymer.CaseMap.dashToCamelCase(category),
-        this.computeCategoryDesc(
-            category,
-            enabled ?
-                settings.PermissionValues.ALLOW :
-                settings.PermissionValues.BLOCK,
-            /*showRecommendation=*/false));
+        enabled ?
+            settings.PermissionValues.ALLOW :
+            settings.PermissionValues.BLOCK);
   },
 
   /**
    * Navigate to the route specified in the event dataset.
    * @param {!Event} event The tap event.
    * @private
    */
   onTapNavigate_: function(event) {
     var dataSet = /** @type {{route: string}} */(event.currentTarget.dataset);
     settings.navigateTo(settings.Route[dataSet.route]);
   },
 });