Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 265983007: Add dump_record to make inspecting before/after SkRecordOptimize easy. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add dump_record to make inspecting before/after SkRecordOptimize easy. E.g. dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp 0 Save 1 DrawRect 2 DrawRect 3 DrawRect 4 DrawRect 5 Save 6 ClipRect 7 Restore 8 Save 9 ClipRect 10 Restore 11 Restore dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp 0 Save 1 DrawRect 2 DrawRect 3 DrawRect 4 DrawRect 5 NoOp 6 NoOp 7 NoOp 8 NoOp 9 NoOp 10 NoOp 11 Restore (Reitveld sadly eats my kickass indentation.) BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14596 Committed: http://code.google.com/p/skia/source/detail?r=14600

Patch Set 1 #

Patch Set 2 : header #

Patch Set 3 : default cause #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/dump_record.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 7 months ago (2014-05-06 18:28:49 UTC) #1
f(malita)
lgtm
6 years, 7 months ago (2014-05-06 19:37:54 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-06 19:38:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/265983007/20001
6 years, 7 months ago (2014-05-06 19:39:08 UTC) #4
commit-bot: I haz the power
Change committed as 14596
6 years, 7 months ago (2014-05-06 19:45:21 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-06 20:31:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/265983007/30001
6 years, 7 months ago (2014-05-06 20:31:57 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 20:38:26 UTC) #8
Message was sent while issue was closed.
Change committed as 14600

Powered by Google App Engine
This is Rietveld 408576698