Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 265983004: Move GetChromeVersion and GetChromePid to CrOSInterface. (Closed)

Created:
6 years, 7 months ago by achuithb
Modified:
6 years, 7 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move GetChromeVersion and GetChromePid to CrOSInterface. BUG=342884 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -47 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 4 chunks +4 lines, -47 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_interface.py View 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
achuithb
No code change.
6 years, 7 months ago (2014-05-02 23:48:10 UTC) #1
Tim Song
lgtm
6 years, 7 months ago (2014-05-05 04:34:39 UTC) #2
achuithb
On 2014/05/05 04:34:39, Tim Song wrote: > lgtm Ty
6 years, 7 months ago (2014-05-05 04:34:55 UTC) #3
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 7 months ago (2014-05-05 16:04:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/265983004/1
6 years, 7 months ago (2014-05-05 16:05:20 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 16:34:07 UTC) #6
Message was sent while issue was closed.
Change committed as 268194

Powered by Google App Engine
This is Rietveld 408576698