Always get device conditions from Java for every attempt.

chrome/browser/android/offline_pages/background_scheduler_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/callback_android.h"
 #include "base/android/scoped_java_ref.h"
 #include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 38 matching lines @@
       GetForBrowserContext(profile);
   DVLOG(2) << "resource_coordinator: " << coordinator;
   DeviceConditions device_conditions(
       j_power_connected, j_battery_percentage,
       static_cast<net::NetworkChangeNotifier::ConnectionType>(
           j_net_connection_type));
   return coordinator->StartScheduledProcessing(
       device_conditions, base::Bind(&ProcessingDoneCallback, j_callback_ref));
 }
 
+BackgroundSchedulerBridge::BackgroundSchedulerBridge() {}

[dewittj, 2017/01/30 19:18:02]

could use = default instead of {}

[Pete Williamson, 2017/01/30 21:35:23]

Done.

+
+BackgroundSchedulerBridge::~BackgroundSchedulerBridge() {}
+
 void BackgroundSchedulerBridge::Schedule(
     const TriggerConditions& trigger_conditions) {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_conditions =
       CreateTriggerConditions(env, trigger_conditions.require_power_connected,
                               trigger_conditions.minimum_battery_percentage,
                               trigger_conditions.require_unmetered_network);
   Java_BackgroundSchedulerBridge_schedule(env, j_conditions);
 }
 
@@ skipping 16 matching lines @@
 ScopedJavaLocalRef<jobject> BackgroundSchedulerBridge::CreateTriggerConditions(
     JNIEnv* env,
     bool require_power_connected,
     int minimum_battery_percentage,
     bool require_unmetered_network) const {
   return Java_BackgroundSchedulerBridge_createTriggerConditions(
       env, require_power_connected, minimum_battery_percentage,
       require_unmetered_network);
 }
 
+DeviceConditions& BackgroundSchedulerBridge::GetCurrentDeviceConditions() {

[dewittj, 2017/01/30 19:18:02]

const

[Pete Williamson, 2017/01/30 21:35:23]

Done.

+  JNIEnv* env = base::android::AttachCurrentThread();
+  // Call the JNI methods to get the device conditions we need.
+  jboolean jpower = Java_BackgroundSchedulerBridge_getPowerConditions(env);
+  jint jbattery = Java_BackgroundSchedulerBridge_getBatteryConditions(env);
+  jint jnetwork = Java_BackgroundSchedulerBridge_getNetworkConditions(env);
+
+  // Cast the java types back to the types we use.
+  bool power = static_cast<bool>(jpower);
+  int battery = static_cast<int>(jbattery);;
+  net::NetworkChangeNotifier::ConnectionType network_connection_type =
+      static_cast<net::NetworkChangeNotifier::ConnectionType>(jnetwork);
+
+  // Now return the current conditions to the caller.
+  device_conditions_ = base::MakeUnique<DeviceConditions>(
+      power, battery, network_connection_type);
+  return *(device_conditions_.get());

[dewittj, 2017/01/30 19:18:02]

I think you can just say *device_conditions_

[Pete Williamson, 2017/01/30 21:35:23]

Done.

+}
+
 bool RegisterBackgroundSchedulerBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace offline_pages