Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2659703002: Implemented StructTraits for cc::CopyOutputResult (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/copy_output_result_struct_traits.cc ('k') | cc/ipc/texture_mailbox_struct_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/struct_traits_unittest.cc
diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc
index b84233bad89a95ff5c26a2fd60da45a13c1b0c67..f7ff218db24ca9e3a215930f0cdb42501245bb03 100644
--- a/cc/ipc/struct_traits_unittest.cc
+++ b/cc/ipc/struct_traits_unittest.cc
@@ -57,6 +57,12 @@ class StructTraitsTest : public testing::Test, public mojom::TraitsTestService {
callback.Run(std::move(c));
}
+ void EchoCopyOutputResult(
+ const CopyOutputResult& c,
+ const EchoCopyOutputResultCallback& callback) override {
+ callback.Run(c);
+ }
+
void EchoFilterOperation(
const FilterOperation& f,
const EchoFilterOperationCallback& callback) override {
@@ -125,6 +131,9 @@ class StructTraitsTest : public testing::Test, public mojom::TraitsTestService {
void StubCopyOutputRequestCallback(std::unique_ptr<CopyOutputResult> result) {}
+void StubCopyOutputResultCallback(const gpu::SyncToken& sync_token,
+ bool is_lost) {}
+
} // namespace
TEST_F(StructTraitsTest, BeginFrameArgs) {
@@ -370,7 +379,6 @@ TEST_F(StructTraitsTest, CopyOutputRequest) {
input = CopyOutputRequest::CreateBitmapRequest(callback);
input->set_area(area);
input->set_source(source);
-
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
CopyOutputRequest output;
proxy->EchoCopyOutputRequest(*input.get(), &output);
@@ -395,6 +403,55 @@ TEST_F(StructTraitsTest, CopyOutputRequest) {
EXPECT_FALSE(output2.has_source());
}
+TEST_F(StructTraitsTest, CopyOutputResult_Bitmap) {
+ auto bitmap = base::MakeUnique<SkBitmap>();
+ bitmap->allocN32Pixels(7, 8);
+ bitmap->eraseARGB(123, 213, 77, 33);
+ auto input = CopyOutputResult::CreateBitmapResult(std::move(bitmap));
+
+ mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
+ CopyOutputResult output;
+ proxy->EchoCopyOutputResult(*input, &output);
+
+ EXPECT_TRUE(output.HasBitmap());
+ EXPECT_FALSE(output.HasTexture());
+ EXPECT_EQ(input->size(), output.size());
+
+ std::unique_ptr<SkBitmap> in_bitmap = input->TakeBitmap();
+ std::unique_ptr<SkBitmap> out_bitmap = output.TakeBitmap();
+ EXPECT_EQ(in_bitmap->getSize(), out_bitmap->getSize());
+ EXPECT_EQ(0, std::memcmp(in_bitmap->getPixels(), out_bitmap->getPixels(),
+ in_bitmap->getSize()));
+}
+
+TEST_F(StructTraitsTest, CopyOutputResult_Texture) {
+ const gfx::Size size(1234, 5678);
+ const int8_t mailbox_name[GL_MAILBOX_SIZE_CHROMIUM] = {
+ 0, 9, 8, 7, 6, 5, 4, 3, 2, 1, 9, 7, 5, 3, 1, 3};
+ const uint32_t target = 3;
+ auto callback =
+ SingleReleaseCallback::Create(base::Bind(StubCopyOutputResultCallback));
+ gpu::Mailbox mailbox;
+ mailbox.SetName(mailbox_name);
+ TextureMailbox texture_mailbox(mailbox, gpu::SyncToken(), target);
+
+ auto input = CopyOutputResult::CreateTextureResult(size, texture_mailbox,
+ std::move(callback));
+
+ mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
+ CopyOutputResult output;
+ proxy->EchoCopyOutputResult(*input, &output);
+
+ EXPECT_FALSE(output.HasBitmap());
+ EXPECT_TRUE(output.HasTexture());
+ EXPECT_EQ(size, output.size());
+
+ TextureMailbox out_mailbox;
+ std::unique_ptr<SingleReleaseCallback> out_callback;
+ output.TakeTexture(&out_mailbox, &out_callback);
+ EXPECT_EQ(mailbox, out_mailbox.mailbox());
+}
+
TEST_F(StructTraitsTest, FilterOperation) {
const FilterOperation inputs[] = {
FilterOperation::CreateBlurFilter(20),
« no previous file with comments | « cc/ipc/copy_output_result_struct_traits.cc ('k') | cc/ipc/texture_mailbox_struct_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698