Implemented StructTraits for cc::CopyOutputResult

cc/ipc/copy_output_result_struct_traits.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_IPC_COPY_OUTPUT_RESULT_STRUCT_TRAITS_H_
+#define CC_IPC_COPY_OUTPUT_RESULT_STRUCT_TRAITS_H_
+
+#include "cc/ipc/copy_output_result.mojom-shared.h"
+#include "cc/output/copy_output_result.h"
+
+namespace mojo {
+
+template <>
+struct StructTraits<cc::mojom::CopyOutputResultDataView, cc::CopyOutputResult> {
+  static const gfx::Size& size(const cc::CopyOutputResult& result) {
+    return result.size_;
+  }
+
+  static const SkBitmap& bitmap(const cc::CopyOutputResult& result) {
+    static SkBitmap null_bitmap_;

[Ken Rockot(use gerrit already), 2017/01/31 20:16:35]

Non-POD static variables are strictly forbidden by the style guide (see
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables).

Please use a base::LazyInstance instead, i.e.

  static base::LazyInstance<SkBitmap> null_bitmap;
  if (!result.bitmap_)
    return null_bitmap.Get();
  return *result.bitmap_;

also naming nit: no trailing underscore, it's not a member variable.

+    if (!result.bitmap_)
+      return null_bitmap_;
+    return *result.bitmap_;
+  }
+
+  static const cc::TextureMailbox& texture_mailbox(
+      const cc::CopyOutputResult& result) {
+    return result.texture_mailbox_;
+  }
+
+  static bool Read(cc::mojom::CopyOutputResultDataView data,
+                   cc::CopyOutputResult* out) {
+    out->bitmap_ = base::MakeUnique<SkBitmap>();
+    return data.ReadSize(&out->size_) && data.ReadBitmap(out->bitmap_.get()) &&
+           data.ReadTextureMailbox(&out->texture_mailbox_);
+  }
+};
+
+}  // namespace mojo
+
+#endif  // CC_IPC_COPY_OUTPUT_RESULT_STRUCT_TRAITS_H_