Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_view_controller.h

Issue 2659693004: Add context menu when long press on a reading list entry (Closed)
Patch Set: Address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
index 262f1854c238ebb8d0947dd58291ec3422747737..2f0797ec1c8c9ff17f8632791e50d1fe29575388 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
+++ b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h
@@ -17,31 +17,39 @@ class LargeIconService;
class ReadingListDownloadService;
class ReadingListModel;
+@class ReadingListViewController;
@class TabModel;
-// Audience for the ReadingListViewController, managing the visibility of the
-// toolbar and dismissing the Reading List View.
-@protocol ReadingListViewControllerAudience<NSObject>
+// Delegate for the ReadingListViewController, managing the visibility of the
+// toolbar, dismissing the Reading List View and opening elements.
+@protocol ReadingListViewControllerDelegate<NSObject>
// Whether the collection has items.
-- (void)setCollectionHasItems:(BOOL)hasItems;
+- (void)readingListViewController:
+ (ReadingListViewController*)readingListViewController
+ hasItems:(BOOL)hasItems;
// Dismisses the Reading List View.
-- (void)dismiss;
+- (void)dismissReadingListViewController:
+ (ReadingListViewController*)readingListViewController;
+
+// Signals that a long press has been recognized.
+- (void)
+readingListViewController:(ReadingListViewController*)readingListViewController
+ didRecognizeLongPress:(UILongPressGestureRecognizer*)gestureRecognizer
+ duringEdit:(BOOL)duringEdit;
+
+// Opens the entry at the indexPath.
+- (void)readingListViewController:
+ (ReadingListViewController*)readingListViewController
+ openItemAtIndexPath:(NSIndexPath*)indexPath;
@end
@interface ReadingListViewController
: CollectionViewController<ReadingListToolbarActions>
-@property(nonatomic, readonly) ReadingListModel* readingListModel;
-@property(weak, nonatomic, readonly) TabModel* tabModel;
-@property(nonatomic, readonly) favicon::LargeIconService* largeIconService;
-@property(nonatomic, readonly)
- ReadingListDownloadService* readingListDownloadService;
-
- (instancetype)initWithModel:(ReadingListModel*)model
- tabModel:(TabModel*)tabModel
largeIconService:(favicon::LargeIconService*)largeIconService
readingListDownloadService:
(ReadingListDownloadService*)readingListDownloadService
@@ -50,7 +58,14 @@ class ReadingListModel;
- (instancetype)initWithStyle:(CollectionViewControllerStyle)style
NS_UNAVAILABLE;
-@property(nonatomic, weak) id<ReadingListViewControllerAudience> audience;
+@property(nonatomic, weak) id<ReadingListViewControllerDelegate> delegate;
+@property(nonatomic, readonly) ReadingListModel* readingListModel;
+@property(nonatomic, readonly) favicon::LargeIconService* largeIconService;
+@property(nonatomic, readonly)
+ ReadingListDownloadService* readingListDownloadService;
+
+// Reloads all the data from the ReadingListModel.
+- (void)reloadData;
@end

Powered by Google App Engine
This is Rietveld 408576698