Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2659693004: Add context menu when long press on a reading list entry (Closed)
Patch Set: Address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index d00a200a771871f26e12a26c8768eda31acceff9..8ff0b6e8c11635b72ecf2e2d90c10430bf050382 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -91,6 +91,7 @@
#import "ios/chrome/browser/ui/browser_container_view.h"
#import "ios/chrome/browser/ui/browser_view_controller_dependency_factory.h"
#import "ios/chrome/browser/ui/chrome_web_view_factory.h"
+#import "ios/chrome/browser/ui/clipboard_util.h"
#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
#include "ios/chrome/browser/ui/commands/ios_command_ids.h"
@@ -2500,13 +2501,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
title = l10n_util::GetNSStringWithFixup(IDS_IOS_CONTENT_CONTEXT_COPY);
action = ^{
Record(ACTION_COPY_LINK_ADDRESS, isImage, isLink);
- NSURL* url = net::NSURLWithGURL(link);
- NSDictionary* item = @{
- (NSString*)kUTTypeURL : url,
- (NSString*)kUTTypeUTF8PlainText :
- [[url absoluteString] dataUsingEncoding:NSUTF8StringEncoding],
- };
- [[UIPasteboard generalPasteboard] setItems:@[ item ]];
+ StoreURLInPasteboard(link);
};
[_contextMenuCoordinator addItemWithTitle:title action:action];
}
@@ -4382,7 +4377,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
DCHECK(reading_list::switches::IsReadingListEnabled());
UIViewController* vc = [ReadingListViewControllerBuilder
readingListViewControllerInBrowserState:self.browserState
- tabModel:_model];
+ loader:self];
[self presentViewController:vc animated:YES completion:nil];
}

Powered by Google App Engine
This is Rietveld 408576698