Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2659693004: Add context menu when long press on a reading list entry (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/BUILD.gn ('k') | ios/chrome/browser/ui/history/history_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 519fda74863ba4a62320a861087d2f18092e2197..ad0ce680a3cb48084d29e953a67b2b5df8754b98 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -148,6 +148,7 @@
#import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h"
#include "ios/chrome/browser/ui/ui_util.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
+#import "ios/chrome/browser/ui/util/pasteboard_util.h"
#import "ios/chrome/browser/ui/voice/text_to_speech_player.h"
#include "ios/chrome/browser/upgrade/upgrade_center.h"
#import "ios/chrome/browser/web/error_page_content.h"
@@ -2499,13 +2500,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
title = l10n_util::GetNSStringWithFixup(IDS_IOS_CONTENT_CONTEXT_COPY);
action = ^{
Record(ACTION_COPY_LINK_ADDRESS, isImage, isLink);
- NSURL* url = net::NSURLWithGURL(link);
- NSDictionary* item = @{
- (NSString*)kUTTypeURL : url,
- (NSString*)kUTTypeUTF8PlainText :
- [[url absoluteString] dataUsingEncoding:NSUTF8StringEncoding],
- };
- [[UIPasteboard generalPasteboard] setItems:@[ item ]];
+ StoreURLInPasteboard(link);
};
[_contextMenuCoordinator addItemWithTitle:title action:action];
}
@@ -4357,7 +4352,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
DCHECK(reading_list::switches::IsReadingListEnabled());
UIViewController* vc = [ReadingListViewControllerBuilder
readingListViewControllerInBrowserState:self.browserState
- tabModel:_model];
+ loader:self];
[self presentViewController:vc animated:YES completion:nil];
}
« no previous file with comments | « ios/chrome/browser/ui/BUILD.gn ('k') | ios/chrome/browser/ui/history/history_collection_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698