Set kHasSeenWin10PromoPage in local_state instead of in profile prefs.

chrome/browser/ui/webui/welcome_win10_ui.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/welcome_win10_ui.h"
 
 #include <string>
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_features.h"
 #include "chrome/browser/ui/webui/welcome_win10_handler.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "chrome/grit/chrome_unscaled_resources.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
@@ skipping 64 matching lines @@
                                   IDS_WIN10_WELCOME_PIN_LABEL);
 }
 
 }  // namespace
 
 WelcomeWin10UI::WelcomeWin10UI(content::WebUI* web_ui, const GURL& url)
     : content::WebUIController(web_ui) {
   static const char kCssFilePath[] = "welcome.css";
   static const char kJsFilePath[] = "welcome.js";
 
-  Profile* profile = Profile::FromWebUI(web_ui);
-
-  // Store that this profile has been shown the Win10 promo page.
-  profile->GetPrefs()->SetBoolean(prefs::kHasSeenWin10PromoPage, true);
+  // Remember that the Win10 promo page has been shown.
+  g_browser_process->local_state()->SetBoolean(prefs::kHasSeenWin10PromoPage,
+                                               true);
 
   // Determine which variation to show.
   bool is_first_run = !UrlContainsKeyValueInQuery(url, "text", "faster");
   bool is_inline_style = ShouldShowInlineStyleVariant(url);
 
   web_ui->AddMessageHandler(
       base::MakeUnique<WelcomeWin10Handler>(is_inline_style));
 
   content::WebUIDataSource* html_source =
       content::WebUIDataSource::Create(url.host());
 
   AddLocalizedStrings(html_source, is_first_run);
 
   if (is_inline_style) {
     html_source->AddResourcePath(kCssFilePath, IDR_WELCOME_WIN10_INLINE_CSS);
     html_source->AddResourcePath(kJsFilePath, IDR_WELCOME_WIN10_INLINE_JS);
     html_source->SetDefaultResource(IDR_WELCOME_WIN10_INLINE_HTML);
   } else {
     html_source->AddResourcePath(kCssFilePath, IDR_WELCOME_WIN10_SECTIONED_CSS);
     html_source->AddResourcePath(kJsFilePath, IDR_WELCOME_WIN10_SECTIONED_JS);
     html_source->SetDefaultResource(IDR_WELCOME_WIN10_SECTIONED_HTML);
   }
 
   html_source->AddResourcePath("logo-small.png", IDR_PRODUCT_LOGO_64);
   html_source->AddResourcePath("logo-large.png", IDR_PRODUCT_LOGO_128);
 
+  Profile* profile = Profile::FromWebUI(web_ui);

[Peter Kasting, 2017/01/26 21:14:32]

Nit: Or just inline this

[Patrick Monette, 2017/01/26 22:09:13]

Done.

   content::WebUIDataSource::Add(profile, html_source);
 }
 
 WelcomeWin10UI::~WelcomeWin10UI() = default;