Create the directory for the plugin package

Create the directory for the plugin package

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/53f498ad6dccf5a81aee868d8b0b33148c472de2

[Brian Wilkerson, 2017-01-27 17:04:54]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-01-27 17:06:42]

lgtm

https://codereview.chromium.org/2659523006/diff/10008/pkg/analyzer_plugin/REA...
File pkg/analyzer_plugin/README.md (right):

https://codereview.chromium.org/2659523006/diff/10008/pkg/analyzer_plugin/REA...
pkg/analyzer_plugin/README.md:3: A framework for building plugins for the
analysis server.
For server?
Not for analyzer?

[Brian Wilkerson, 2017-01-27 17:15:54]

brianwilkerson@google.com changed reviewers:
+ jamesr@google.com

[Brian Wilkerson, 2017-01-27 17:15:54]

James, could you look at the BUILD file? I was originally assuming that the
'deps' are the transitive closure of all reachable packages rather than direct
dependencies, but now I think I might have been wrong.

[Brian Wilkerson, 2017-01-27 17:18:15]

https://codereview.chromium.org/2659523006/diff/10008/pkg/analyzer_plugin/REA...
File pkg/analyzer_plugin/README.md (right):

https://codereview.chromium.org/2659523006/diff/10008/pkg/analyzer_plugin/REA...
pkg/analyzer_plugin/README.md:3: A framework for building plugins for the
analysis server.
For server for the short term. I think eventually it will also be used by CLI.

[jamesr, 2017-01-30 19:30:47]

On 2017/01/27 at 17:15:54, brianwilkerson wrote:
> James, could you look at the BUILD file? I was originally assuming that the
'deps' are the transitive closure of all reachable packages rather than direct
dependencies, but now I think I might have been wrong.

Hi Brian - the deps listed in a BUILD.gn file only need to be the direct
dependencies, assuming that the direct dependencies themselves express their
dependencies correctly.  The dependencies for packages listed under
//third_party/dart-pkg/pub/ are machine-generated from the pubspec.yaml file, so
they should be fine.  For other targets, if you observe what appear to be
missing transitive dependencies the problem likely is in a downstream package. 
You can examine how the BUILD.gn files are being interpreted and used by
examining the generated files, happy to give pointers if you're interested in
digging in.

[Brian Wilkerson, 2017-01-30 21:21:17]

Thanks! I'll pare it down before committing.

[Brian Wilkerson, 2017-01-30 21:21:43]

Description was changed from

==========
Create the directory for the plugin package
==========

to

==========
Create the directory for the plugin package

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53f498ad6dccf5a81aee868d8b0b33148c472de2
==========

[Brian Wilkerson, 2017-01-30 21:21:44]

Committed patchset #2 (id:10008) manually as
53f498ad6dccf5a81aee868d8b0b33148c472de2 (presubmit successful).