Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Issue 2659523004: Comment a DCHECK that fails temporarily (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/PointerEventFactory.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
index c7ea47128bdca0d0a62f243e737f1c4282f2f278..4293ed1531b24e9f965d54d911ae625eadd4d7c8 100644
--- a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
@@ -269,8 +269,10 @@ PointerEvent* PointerEventFactory::create(
for (const auto& coalescedMouseEvent : coalescedMouseEvents) {
DCHECK_EQ(mouseEvent.pointerProperties().id,
coalescedMouseEvent.pointerProperties().id);
- DCHECK_EQ(mouseEvent.pointerProperties().pointerType,
- coalescedMouseEvent.pointerProperties().pointerType);
+ // TODO(crbug.com/684292): We need further investigation of why the
+ // following DCHECK fails.
+ // DCHECK_EQ(mouseEvent.pointerProperties().pointerType,
+ // coalescedMouseEvent.pointerProperties().pointerType);
PointerEventInit coalescedEventInit = pointerEventInit;
updateMousePointerEventInit(coalescedMouseEvent, view,
&coalescedEventInit);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698