Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2659403002: Fix hints and warnings. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Paul Berry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 819182a4c5788bc3e6302522c792d385a11e273e. #

Patch Set 3 : Undo changes to core_types.dart #

Patch Set 4 : Rebased on e4c8a99f67f6846dffae69d1f4c745f1085d2680. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/mock_type.dart View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahe
Paul: can I modify pkg/analyzer/lib/src/generated/error_verifier.dart?
3 years, 10 months ago (2017-01-30 14:39:49 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-01-30 14:52:49 UTC) #3
Paul Berry
Analyzer change lgtm
3 years, 10 months ago (2017-01-30 16:39:56 UTC) #5
ahe
Johnni, could you take another look, I rebased the change, and there was a few ...
3 years, 10 months ago (2017-01-31 11:33:52 UTC) #6
Johnni Winther
lgtm
3 years, 10 months ago (2017-01-31 11:36:38 UTC) #7
ahe
3 years, 10 months ago (2017-02-01 12:04:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0401b897958de33f8481b9cb323eab53106a3ce9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698