Issue 26594008: Remove need for readFlattenableT from SkLightingImageFilter.

Issue 26594008: Remove need for readFlattenableT from SkLightingImageFilter. (Closed)

Created:
7 years, 2 months ago by mtklein

Modified:
7 years, 2 months ago

Reviewers:
reed, Stephen White, sugoi, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove need for readFlattenableT from SkLightingImageFilter. This will need new picture version. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11758

Patch Set 3 : unflatten/Unflatten #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -31 lines)			Patch
	M	src/effects/SkLightingImageFilter.cpp	View	1 2	11 chunks	+45 lines, -31 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm w/ Capitalization nit https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp File src/effects/SkLightingImageFilter.cpp (right): https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp#newcode531 src/effects/SkLightingImageFilter.cpp:531: static SkLight* unflattenLight(SkFlattenableReadBuffer& buffer); statics ...

7 years, 2 months ago (2013-10-14 13:08:51 UTC) #4

mtklein

https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp File src/effects/SkLightingImageFilter.cpp (right): https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp#newcode531 src/effects/SkLightingImageFilter.cpp:531: static SkLight* unflattenLight(SkFlattenableReadBuffer& buffer); On 2013/10/14 13:08:51, reed1 wrote: ...

7 years, 2 months ago (2013-10-14 15:50:54 UTC) #5

mtklein

On 2013/10/14 15:50:54, mtklein wrote: > https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp > File src/effects/SkLightingImageFilter.cpp (right): > > https://codereview.chromium.org/26594008/diff/1002/src/effects/SkLightingImageFilter.cpp#newcode531 > ...

7 years, 2 months ago (2013-10-14 16:21:28 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26594008/9001

7 years, 2 months ago (2013-10-14 16:21:42 UTC) #7

Message was sent while issue was closed.

Change committed as 11758

Expand Messages | Collapse Messages