Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2659333003: fix SourceFactoryImpl restoreUri (Closed)

Created:
3 years, 10 months ago by danrubel
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M pkg/analyzer/lib/src/context/source.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A pkg/analyzer/test/src/context/source_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 10 months ago (2017-01-30 17:21:15 UTC) #2
scheglov
lgtm
3 years, 10 months ago (2017-01-30 17:25:47 UTC) #3
danrubel
3 years, 10 months ago (2017-01-30 18:05:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
39b6fc1287870ebcc9dc33020706ba3bbc5195ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698