Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 265933006: Fix Telemetry to calculate bounding visible rect correctly. (Closed)

Created:
6 years, 7 months ago by e.hakkinen
Modified:
6 years, 7 months ago
Reviewers:
Dominik Grewe, bulach, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix Telemetry to calculate bounding visible rect correctly. Fixes the parts of bounding client rects which are to the left or to the top of the visible area not to visible (in addition to the parts which are to the right or to the bottom of the visible area). Enhances the corresponding unittest to test these cases, too. BUG=369479 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M tools/telemetry/telemetry/page/actions/gesture_common.js View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
e.hakkinen
6 years, 7 months ago (2014-05-05 07:54:28 UTC) #1
e.hakkinen
Without this patch pincing, scrolling, swiping and tapping synthesized by Telemetry on a scrolled page ...
6 years, 7 months ago (2014-05-07 08:54:32 UTC) #2
Dominik Grewe
Sorry for the delay. LGTM but you still need owner's approval.
6 years, 7 months ago (2014-05-07 09:20:49 UTC) #3
bulach
lgtm, thanks!
6 years, 7 months ago (2014-05-07 09:22:41 UTC) #4
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 7 months ago (2014-05-07 10:02:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/265933006/1
6 years, 7 months ago (2014-05-07 10:06:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 16:11:27 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 18:24:35 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 19:55:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium
6 years, 7 months ago (2014-05-07 19:55:53 UTC) #10
e.hakkinen
The CQ bit was checked by e.hakkinen@partner.samsung.com
6 years, 7 months ago (2014-05-08 08:47:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@partner.samsung.com/265933006/1
6 years, 7 months ago (2014-05-08 08:47:53 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 00:06:30 UTC) #13
Message was sent while issue was closed.
Change committed as 269116

Powered by Google App Engine
This is Rietveld 408576698