Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 26592012: Prevent changes to hidden properties from being observable via Object.observe (Closed)

Created:
7 years, 2 months ago by rafaelw
Modified:
7 years, 2 months ago
CC:
v8-dev, Michael Starzinger, adamk
Visibility:
Public.

Description

Prevent changes to hidden properties from being observable via Object.observe This addresses the leak that mstarzinger points out (https://codereview.chromium.org/26390003/) and includes the test. Note that this adds a test that observing changes to the empty-string property remains possible. BUG= R=mstarzinger@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17257

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M src/objects.cc View 1 6 chunks +17 lines, -7 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
PTAL. Let me know if you'd like to see a helper for computing is_observed for ...
7 years, 2 months ago (2013-10-16 22:34:52 UTC) #1
rossberg
LGTM Don't think a helper is necessary, considering that 2 thirds of the condition should ...
7 years, 2 months ago (2013-10-17 09:10:05 UTC) #2
rossberg
LGTM Don't think a helper is necessary, considering that 2 thirds of the condition should ...
7 years, 2 months ago (2013-10-17 09:10:06 UTC) #3
Michael Starzinger
Drive-by LGTM.
7 years, 2 months ago (2013-10-17 11:35:03 UTC) #4
rafaelw
7 years, 2 months ago (2013-10-17 20:49:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698