Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 213
214 bool V8TestInterfaceImplementedAs::HasInstanceInAnyWorld(v8::Handle<v8::Value> v alue, v8::Isolate* isolate) 214 bool V8TestInterfaceImplementedAs::HasInstanceInAnyWorld(v8::Handle<v8::Value> v alue, v8::Isolate* isolate)
215 { 215 {
216 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld) 216 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
217 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld) 217 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld)
218 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d); 218 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d);
219 } 219 }
220 220
221 v8::Handle<v8::Object> V8TestInterfaceImplementedAs::createWrapper(PassRefPtr<Re alClass> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 221 v8::Handle<v8::Object> V8TestInterfaceImplementedAs::createWrapper(PassRefPtr<Re alClass> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
222 { 222 {
223 ASSERT(impl.get()); 223 ASSERT(impl);
224 ASSERT(!DOMDataStore::containsWrapper<V8TestInterfaceImplementedAs>(impl.get (), isolate)); 224 ASSERT(!DOMDataStore::containsWrapper<V8TestInterfaceImplementedAs>(impl.get (), isolate));
225 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) { 225 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
226 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get()); 226 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get());
227 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have 227 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
228 // the same object de-ref functions, though, so use that as the basis of the check. 228 // the same object de-ref functions, though, so use that as the basis of the check.
229 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction); 229 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
230 } 230 }
231 231
232 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate); 232 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate);
233 if (UNLIKELY(wrapper.IsEmpty())) 233 if (UNLIKELY(wrapper.IsEmpty()))
234 return wrapper; 234 return wrapper;
235 235
236 installPerContextProperties(wrapper, impl.get(), isolate); 236 installPerContextProperties(wrapper, impl.get(), isolate);
237 V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceImplementedAs>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent); 237 V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceImplementedAs>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent);
238 return wrapper; 238 return wrapper;
239 } 239 }
240 240
241 void V8TestInterfaceImplementedAs::derefObject(void* object) 241 void V8TestInterfaceImplementedAs::derefObject(void* object)
242 { 242 {
243 fromInternalPointer(object)->deref(); 243 fromInternalPointer(object)->deref();
244 } 244 }
245 245
246 } // namespace WebCore 246 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceEmpty.cpp ('k') | Source/bindings/tests/results/V8TestMediaQueryListListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698