Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: Source/bindings/tests/results/V8TestConstants.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 bool V8TestConstants::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8::Iso late* isolate) 145 bool V8TestConstants::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8::Iso late* isolate)
146 { 146 {
147 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld) 147 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
148 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld) 148 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld)
149 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d); 149 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d);
150 } 150 }
151 151
152 v8::Handle<v8::Object> V8TestConstants::createWrapper(PassRefPtr<TestConstants> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 152 v8::Handle<v8::Object> V8TestConstants::createWrapper(PassRefPtr<TestConstants> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
153 { 153 {
154 ASSERT(impl.get()); 154 ASSERT(impl);
155 ASSERT(!DOMDataStore::containsWrapper<V8TestConstants>(impl.get(), isolate)) ; 155 ASSERT(!DOMDataStore::containsWrapper<V8TestConstants>(impl.get(), isolate)) ;
156 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) { 156 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
157 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get()); 157 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get());
158 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have 158 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
159 // the same object de-ref functions, though, so use that as the basis of the check. 159 // the same object de-ref functions, though, so use that as the basis of the check.
160 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction); 160 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
161 } 161 }
162 162
163 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate); 163 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate);
164 if (UNLIKELY(wrapper.IsEmpty())) 164 if (UNLIKELY(wrapper.IsEmpty()))
165 return wrapper; 165 return wrapper;
166 166
167 installPerContextProperties(wrapper, impl.get(), isolate); 167 installPerContextProperties(wrapper, impl.get(), isolate);
168 V8DOMWrapper::associateObjectWithWrapper<V8TestConstants>(impl, &info, wrapp er, isolate, WrapperConfiguration::Independent); 168 V8DOMWrapper::associateObjectWithWrapper<V8TestConstants>(impl, &info, wrapp er, isolate, WrapperConfiguration::Independent);
169 return wrapper; 169 return wrapper;
170 } 170 }
171 171
172 void V8TestConstants::derefObject(void* object) 172 void V8TestConstants::derefObject(void* object)
173 { 173 {
174 fromInternalPointer(object)->deref(); 174 fromInternalPointer(object)->deref();
175 } 175 }
176 176
177 } // namespace WebCore 177 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestActiveDOMObject.cpp ('k') | Source/bindings/tests/results/V8TestCustomAccessors.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698