Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/bindings/tests/results/V8TestActiveDOMObject.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 244
245 bool V8TestActiveDOMObject::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v 8::Isolate* isolate) 245 bool V8TestActiveDOMObject::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v 8::Isolate* isolate)
246 { 246 {
247 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld) 247 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
248 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld) 248 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld)
249 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d); 249 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d);
250 } 250 }
251 251
252 v8::Handle<v8::Object> V8TestActiveDOMObject::createWrapper(PassRefPtr<TestActiv eDOMObject> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 252 v8::Handle<v8::Object> V8TestActiveDOMObject::createWrapper(PassRefPtr<TestActiv eDOMObject> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
253 { 253 {
254 ASSERT(impl.get()); 254 ASSERT(impl);
255 ASSERT(!DOMDataStore::containsWrapper<V8TestActiveDOMObject>(impl.get(), iso late)); 255 ASSERT(!DOMDataStore::containsWrapper<V8TestActiveDOMObject>(impl.get(), iso late));
256 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) { 256 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
257 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get()); 257 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get());
258 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have 258 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
259 // the same object de-ref functions, though, so use that as the basis of the check. 259 // the same object de-ref functions, though, so use that as the basis of the check.
260 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction); 260 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
261 } 261 }
262 262
263 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate); 263 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate);
264 if (UNLIKELY(wrapper.IsEmpty())) 264 if (UNLIKELY(wrapper.IsEmpty()))
265 return wrapper; 265 return wrapper;
266 266
267 installPerContextProperties(wrapper, impl.get(), isolate); 267 installPerContextProperties(wrapper, impl.get(), isolate);
268 V8DOMWrapper::associateObjectWithWrapper<V8TestActiveDOMObject>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent); 268 V8DOMWrapper::associateObjectWithWrapper<V8TestActiveDOMObject>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent);
269 return wrapper; 269 return wrapper;
270 } 270 }
271 271
272 void V8TestActiveDOMObject::derefObject(void* object) 272 void V8TestActiveDOMObject::derefObject(void* object)
273 { 273 {
274 fromInternalPointer(object)->deref(); 274 fromInternalPointer(object)->deref();
275 } 275 }
276 276
277 } // namespace WebCore 277 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8Float64Array.cpp ('k') | Source/bindings/tests/results/V8TestConstants.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698