Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2659183002: [RootLayerScrolls] Fix frame scrolling layer in ScrollingCoordinator (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 // corner is setNeedsPaintInvalidation. 315 // corner is setNeedsPaintInvalidation.
316 virtual void scrollControlWasSetNeedsPaintInvalidation() = 0; 316 virtual void scrollControlWasSetNeedsPaintInvalidation() = 0;
317 317
318 // Returns the default scroll style this area should scroll with when not 318 // Returns the default scroll style this area should scroll with when not
319 // explicitly specified. E.g. The scrolling behavior of an element can be 319 // explicitly specified. E.g. The scrolling behavior of an element can be
320 // specified in CSS. 320 // specified in CSS.
321 virtual ScrollBehavior scrollBehaviorStyle() const { 321 virtual ScrollBehavior scrollBehaviorStyle() const {
322 return ScrollBehaviorInstant; 322 return ScrollBehaviorInstant;
323 } 323 }
324 324
325 virtual bool isScrollable() const { return true; }
326
325 // TODO(bokan): FrameView::setScrollOffset uses updateScrollbars to scroll 327 // TODO(bokan): FrameView::setScrollOffset uses updateScrollbars to scroll
326 // which bails out early if its already in updateScrollbars, the effect being 328 // which bails out early if its already in updateScrollbars, the effect being
327 // that programmatic scrolls (i.e. setScrollOffset) are disabled when in 329 // that programmatic scrolls (i.e. setScrollOffset) are disabled when in
328 // updateScrollbars. Expose this here to allow RootFrameViewport to match the 330 // updateScrollbars. Expose this here to allow RootFrameViewport to match the
329 // semantics for now but it should be cleaned up at the source. 331 // semantics for now but it should be cleaned up at the source.
330 virtual bool isProgrammaticallyScrollable() { return true; } 332 virtual bool isProgrammaticallyScrollable() { return true; }
331 333
332 // Subtracts space occupied by this ScrollableArea's scrollbars. 334 // Subtracts space occupied by this ScrollableArea's scrollbars.
333 // Does nothing if overlay scrollbars are enabled. 335 // Does nothing if overlay scrollbars are enabled.
334 IntSize excludeScrollbars(const IntSize&) const; 336 IntSize excludeScrollbars(const IntSize&) const;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 // vertical-lr / ltr NO NO 451 // vertical-lr / ltr NO NO
450 // vertical-lr / rtl NO YES 452 // vertical-lr / rtl NO YES
451 // vertical-rl / ltr YES NO 453 // vertical-rl / ltr YES NO
452 // vertical-rl / rtl YES YES 454 // vertical-rl / rtl YES YES
453 IntPoint m_scrollOrigin; 455 IntPoint m_scrollOrigin;
454 }; 456 };
455 457
456 } // namespace blink 458 } // namespace blink
457 459
458 #endif // ScrollableArea_h 460 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698