Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: cc/scheduler/scheduler.h

Issue 2659123004: cc: Add scheduler support for invalidating content on impl thread. (Closed)
Patch Set: commit_to_active Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/scheduler.cc » ('j') | cc/scheduler/scheduler_state_machine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index afc2247ec02d44af1bcdc54b6f6d85d2168ff2a5..42c9d2e16aa49058c938d6c2db22807ba94cb224 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -45,6 +45,7 @@ class SchedulerClient {
virtual void ScheduledActionBeginCompositorFrameSinkCreation() = 0;
virtual void ScheduledActionPrepareTiles() = 0;
virtual void ScheduledActionInvalidateCompositorFrameSink() = 0;
+ virtual void ScheduledActionRunImplSideInvalidation() = 0;
virtual void DidFinishImplFrame() = 0;
virtual void SendBeginMainFrameNotExpectedSoon() = 0;
@@ -89,6 +90,15 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void SetNeedsPrepareTiles();
+ // Requests a pending tree should be created to invalidate content on the impl
+ // thread, after the current tree is activated, if any. If the request
+ // necessitates creating a pending tree only for impl-side invalidations, the
+ // |client_| is informed to perform this action using
+ // ScheduledActionRunImplSideInvalidation.
+ // If ScheduledActionCommit is performed, the impl-side invalidations should
+ // be merged with the main frame and the request is assumed to be completed.
+ void SetNeedsImplSideInvalidation();
brianderson 2017/02/03 00:54:53 Would SetNeedsInvalidatePendingTree be a better na
brianderson 2017/02/03 00:54:53 Oh - I see that it invalidates the active tree too
Khushal 2017/02/03 01:45:11 ImplSideInvalidation seemed better to keep it gene
+
// Drawing should result in submitting a CompositorFrame to the
// CompositorFrameSink and then calling this.
void DidSubmitCompositorFrame();
« no previous file with comments | « no previous file | cc/scheduler/scheduler.cc » ('j') | cc/scheduler/scheduler_state_machine.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698