Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2659063002: Fix DOM constructors in inline JS (Closed)

Created:
3 years, 10 months ago by vsm
Modified:
3 years, 10 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : restrict to containing extension class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -639 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 80 chunks +154 lines, -154 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 80 chunks +154 lines, -154 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 80 chunks +154 lines, -154 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 80 chunks +154 lines, -154 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 2 chunks +23 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 4 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vsm
3 years, 10 months ago (2017-01-27 13:36:08 UTC) #2
Jacob
lgtm https://codereview.chromium.org/2659063002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2659063002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode3733 pkg/dev_compiler/lib/src/compiler/code_generator.dart:3733: // in dart:html itself. Alternately, only apply this ...
3 years, 10 months ago (2017-01-27 16:10:31 UTC) #3
vsm
On 2017/01/27 16:10:31, Jacob wrote: > lgtm > > https://codereview.chromium.org/2659063002/diff/1/pkg/dev_compiler/lib/src/compiler/code_generator.dart > File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): > ...
3 years, 10 months ago (2017-01-27 16:47:03 UTC) #4
Jacob
lgtm has to be a record for number of real dart:html fixes in one cl.
3 years, 10 months ago (2017-01-27 17:34:32 UTC) #5
vsm
3 years, 10 months ago (2017-01-27 17:47:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
50ccf6d9b5d562619752860f92960ff3ce7fcbe1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698