[SAB] Test262 Agent harness

test/test262/testcfg.py

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 97 matching lines @@
 class Test262TestSuite(testsuite.TestSuite):
   # Match the (...) in '/path/to/v8/test/test262/subdir/test/(...).js'
   # In practice, subdir is data or local-tests
 
   def __init__(self, name, root):
     super(Test262TestSuite, self).__init__(name, root)
     self.testroot = os.path.join(self.root, *TEST_262_SUITE_PATH)
     self.harnesspath = os.path.join(self.root, *TEST_262_HARNESS_PATH)
     self.harness = [os.path.join(self.harnesspath, f)
                     for f in TEST_262_HARNESS_FILES]
-    self.harness += [os.path.join(self.root, "harness-adapt.js")]
+    self.harness += [os.path.join(self.root, "harness-adapt.js"),
+                     os.path.join(self.root, "harness-agent.js")]

[Dan Ehrenberg, 2017/01/28 03:41:06]

It would be nice if you could avoid including this file for tests that don't
need the SharedArrayBuffer test infrastructure, especially if it allocates a
SharedArrayBuffer unconditionally, but even if it doesn't, as test262 is already
relatively slow to run and loading another script could make it slower. This is
what is done below for detachArrayBuffer.js. It sounds like the logic could be,
"if it's in built-ins/Atomics, built-ins/SharedArrayBuffer, or has the
SharedArrayBuffer feature tag, you need harness-agent.js".

[binji, 2017/02/18 01:07:59]

Done.

     self.localtestroot = os.path.join(self.root, *TEST_262_LOCAL_TESTS_PATH)
     self.ParseTestRecord = None
 
   def ListTests(self, context):
     tests = []
     testnames = set()
     for dirname, dirs, files in itertools.chain(os.walk(self.testroot),
                                                 os.walk(self.localtestroot)):
       for dotted in [x for x in dirs if x.startswith(".")]:
         dirs.remove(dotted)
@@ skipping 15 matching lines @@
     return (testcase.flags + context.mode_flags + self.harness +
             self.GetIncludesForTest(testcase) +
             (["--module"] if "module" in self.GetTestRecord(testcase) else []) +
             [self.GetPathForTest(testcase)] +
             (["--throws"] if "negative" in self.GetTestRecord(testcase)
                           else []) +
             (["--allow-natives-syntax"]
              if "detachArrayBuffer.js" in
                 self.GetTestRecord(testcase).get("includes", [])
              else []) +
+            (["--harmony-sharedarraybuffer"]) +

[Dan Ehrenberg, 2017/01/28 03:41:06]

It would be nice to avoid passing this flag for tests that don't use
SharedArrayBuffer. It's better to be running the test262 tests in something
close to the production configuration, generally, except for in-progress
features. Could you instead put the references to "--harmony-sharedarraybuffer"
in test262.status for the tests that should have the flag passed?

To make this work, you'd actually either have to pull in the test262 tests
locally or wait until they are committed upstream and do a test262 roll. It'd be
ideal if the infrastructure is checked in together with running the tests, so we
actually get coverage of both. For more information on local test262 tests and
per-test flags, see
https://docs.google.com/document/d/16bj7AIDgZLv4WOsUEzQ5NzcEN9_xo095e88Pz8FC5...
. Note that, in the status file, you can list a whole subdirectory of tests as
needing a flag by doing something like "built-ins/Atomics/*":
["--harmony-sharedarraybuffer"]

[binji, 2017/02/18 01:07:59]

Done.

             ([flag for flag in testcase.outcomes if flag.startswith("--")]))
 
   def _VariantGeneratorFactory(self):
     return Test262VariantGenerator
 
   def LoadParseTestRecord(self):
     if not self.ParseTestRecord:
       root = os.path.join(self.root, *TEST_262_TOOLS_PATH)
       f = None
       try:
@@ skipping 67 matching lines @@
     # data folder.
     if os.path.exists(ARCHIVE) and not os.path.exists(DATA):
       print "Extracting archive..."
       tar = tarfile.open(ARCHIVE)
       tar.extractall(path=os.path.dirname(ARCHIVE))
       tar.close()
 
 
 def GetSuite(name, root):
   return Test262TestSuite(name, root)