Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 265883009: Build cleanup following r21126. Marking Native* methods in object-observe.js as knownProblems in fu… (Closed)

Created:
6 years, 7 months ago by rafaelw
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Build cleanup following r21126. Marking Native* methods in object-observe.js as knownProblems in fuzz-natives TBR=verwaest Committed: https://code.google.com/p/v8/source/detail?r=21127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/mjsunit/fuzz-natives-part2.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rafaelw
Committed patchset #1 manually as r21127 (presubmit successful).
6 years, 7 months ago (2014-05-02 17:31:30 UTC) #1
Jakob Kummerow
Not LGTM. Instead of blacklisting those functions from fuzz-natives, please fix them to handle any ...
6 years, 7 months ago (2014-05-02 19:23:01 UTC) #2
adamk
6 years, 7 months ago (2014-05-02 20:21:59 UTC) #3
Message was sent while issue was closed.
On 2014/05/02 19:23:01, Jakob wrote:
> Not LGTM. Instead of blacklisting those functions from fuzz-natives, please
fix
> them to handle any input without crashing, e.g. you can use:
> 
> CONVERT_ARG_HANDLE_CHECKED(HeapObject, ...);
> 
> or if you need more flexibility:
> 
> RUNTIME_ASSERT(foo->IsHeapObject() || foo->IsBar());

Handled in https://codereview.chromium.org/264793015/

Powered by Google App Engine
This is Rietveld 408576698