Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 2658733002: VM: Remove unused optimization of merging of sin/cos. (Closed)
Patch Set: Remove now unused representation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 2238 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 if (right < 0) { 2249 if (right < 0) {
2250 remainder -= right; 2250 remainder -= right;
2251 } else { 2251 } else {
2252 remainder += right; 2252 remainder += right;
2253 } 2253 }
2254 } 2254 }
2255 return remainder; 2255 return remainder;
2256 } 2256 }
2257 2257
2258 2258
2259 void SinCos(double arg, double* cos_res, double* sin_res) {
2260 // The compiler may merge the calls to sincos, if supported. This
2261 // typically occurs only when compiling for 64-bit targets.
2262 *cos_res = cos(arg);
2263 *sin_res = sin(arg);
2264 }
2265
2266
2267 // Update global type feedback recorded for a field recording the assignment 2259 // Update global type feedback recorded for a field recording the assignment
2268 // of the given value. 2260 // of the given value.
2269 // Arg0: Field object; 2261 // Arg0: Field object;
2270 // Arg1: Value that is being stored. 2262 // Arg1: Value that is being stored.
2271 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) { 2263 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
2272 const Field& field = Field::CheckedHandle(arguments.ArgAt(0)); 2264 const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
2273 const Object& value = Object::Handle(arguments.ArgAt(1)); 2265 const Object& value = Object::Handle(arguments.ArgAt(1));
2274 field.RecordStore(value); 2266 field.RecordStore(value);
2275 } 2267 }
2276 2268
(...skipping 15 matching lines...) Expand all
2292 const intptr_t elm_size = old_data.ElementSizeInBytes(); 2284 const intptr_t elm_size = old_data.ElementSizeInBytes();
2293 const TypedData& new_data = 2285 const TypedData& new_data =
2294 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld)); 2286 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld));
2295 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size); 2287 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size);
2296 typed_data_cell.SetAt(0, new_data); 2288 typed_data_cell.SetAt(0, new_data);
2297 arguments.SetReturn(new_data); 2289 arguments.SetReturn(new_data);
2298 } 2290 }
2299 2291
2300 2292
2301 } // namespace dart 2293 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698